-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Tracing #326
Comments
Sure, though I would go straight to Open Telemetry. |
Great, then let me work on it |
@mattklein123 Have a question in mind: if we are going to send out OTEL span when calling memcached and redis, it probably needs the caller to pass the parent traceId in gRPC request body, which isn't around for now according to the https://github.com/envoyproxy/envoy/blob/main/api/envoy/service/ratelimit/v2/rls.proto Should we consider to add such data in the ratelimit request protocol? Also we will need to add the implementation in envoyproxy in order to produce a full trace. |
Yeah we can add this to the API for sure. |
Nice, then let me finish the implementation from ratelimit side first |
Can we close this if it was taken care of by #332 ? |
I am experiencing some difficulty when troubleshooting a slow ratelimit installation. I believe adding tracing of any format (preferrably zipkin or openTelemetry) to the ratelimit service can be of great help.
Happy to submit a PR if this is ok.
The text was updated successfully, but these errors were encountered: