Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nonce as EOSEVM version and map to EVMC revision #82

Closed
Tracked by #237
stephenpdeos opened this issue Nov 1, 2023 · 0 comments · Fixed by #78
Closed
Tracked by #237

Use nonce as EOSEVM version and map to EVMC revision #82

stephenpdeos opened this issue Nov 1, 2023 · 0 comments · Fixed by #78
Assignees

Comments

@stephenpdeos
Copy link
Member

stephenpdeos commented Nov 1, 2023

The silkworm library handles the information of EVM revisions that needs to be activated at specific block heights by maintaining a static structure (ChainConfig) for each supported network.

In order to keep most of the silkworm code as it is we want to keep this structure, but change the way the active EVMC revision is obtained for the case of networks using the Trust Ruleset.

In this case (Trust Ruleset) the EVMC revision must be retrieved from the mapping of the EOSEVM version coming from the nonce field of the block header of the current block.

For other RuleSet, the current behavior should be mantained in order for tests to pass.

This is a WIP for the ChainConfig refactor:
https://github.com/eosnetworkfoundation/silkworm/tree/elmato/chain-config-refactor

@stephenpdeos stephenpdeos converted this from a draft issue Nov 1, 2023
@stephenpdeos stephenpdeos changed the title Use nonce as EOSEVM version and map to EOSEVMC revision Use nonce as EOSEVM version and map to EVMC revision Nov 1, 2023
@stephenpdeos stephenpdeos assigned yarkinwho and unassigned taokayan Dec 20, 2023
@yarkinwho yarkinwho moved this from Todo to Awaiting Review in EOS EVM Jan 2, 2024
@stephenpdeos stephenpdeos assigned elmato and unassigned yarkinwho Jan 3, 2024
@elmato elmato linked a pull request Jan 4, 2024 that will close this issue
@elmato elmato moved this from Awaiting Review to In Progress in EOS EVM Jan 5, 2024
@elmato elmato moved this from In Progress to Awaiting Review in EOS EVM Jan 10, 2024
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in EOS EVM Jan 11, 2024
@stephenpdeos stephenpdeos added this to the Next Silkworm Release milestone May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants