Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the port numbers or not on API endpoints when port number is 'standard' #18

Open
matthewdarwin opened this issue Jul 6, 2018 · 2 comments

Comments

@matthewdarwin
Copy link
Contributor

The readme specifies that port numbers should be specified on API endpoints:

api_endpoint: EOSIO HTTP endpoint http://host:port
ssl_endpoint: EOSIO HTTPS endpoint https://host:port

However, when it is a standard port (80 or 443), the normal convention is to leave it off, when it is the standard port (https://tools.ietf.org/html/rfc3986#section-3.2.3)

So should the readme be amended to follow RFC 3986 convention or we always want the port number?

The validator at https://validate.eosnation.io currently follwows RFC 3986, which is not aligned to the documentation.

@matthewdarwin matthewdarwin changed the title should the port numbers or not on API endpoints Show the port numbers or not on API endpoints when port number is 'standard' Jul 6, 2018
@nsjames
Copy link
Collaborator

nsjames commented Jul 6, 2018

I think for congruency they should be left on. In any case if any user or machine navigates to the url it will strip them but for machines it'll serve as a delimiter for standardized URLs

@blokcrafter-dan
Copy link

I think we should follow RFC's when one is available. Here, one is. Drop the port if it's the standard port.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants