Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Invalid 0 precision token handling /get_tokens #131

Open
Avm07 opened this issue Nov 23, 2022 · 4 comments
Open

[BUG] Invalid 0 precision token handling /get_tokens #131

Avm07 opened this issue Nov 23, 2022 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Avm07
Copy link

Avm07 commented Nov 23, 2022

For 0 precision tokens missing precision field at /get_tokens response data

Example:

curl -X 'GET' \
  'https://hyperion.paycash.online/v2/state/get_tokens?account=i.list' \
  -H 'accept: application/json'

Logical estimate that field will be present:

{
      "symbol": "LQAG",
      "precision": 0,
      "amount": 0,
      "contract": "swap.pcash"
}

@Avm07 Avm07 changed the title Invalid 0 precision token handling /get_tokens [BUG] Invalid 0 precision token handling /get_tokens Nov 23, 2022
@chuck-h
Copy link

chuck-h commented Jan 18, 2023

FYI @igorls looked at this a few months ago and thought it was ok
image

@Avm07
Copy link
Author

Avm07 commented Feb 6, 2023

FYI @igorls looked at this a few months ago and thought it was ok image

I talked before with him and it's not right. Check the contract source, asset always has a precision field and amount. Displaying precision = 0 is a correct statement. Undefined is not acceptable in this case.

@chuck-h
Copy link

chuck-h commented Feb 6, 2023

@Avm07 I agree with you it's not right and I'm glad to hear that @igorls agrees now too.

@igorls
Copy link
Member

igorls commented Feb 6, 2023

Thanks for opening the issue, we will get that patched soon

@igorls igorls self-assigned this May 18, 2024
@igorls igorls added this to the v3.4 milestone May 18, 2024
@igorls igorls added the bug Something isn't working label May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants