Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up logging #31

Open
shroffk opened this issue Apr 24, 2018 · 2 comments
Open

Clean up logging #31

shroffk opened this issue Apr 24, 2018 · 2 comments

Comments

@shroffk
Copy link
Contributor

shroffk commented Apr 24, 2018

Use of global logger should be replaced by names logger.

@willrogers
Copy link
Contributor

The global logger seems to be used for a 'context logger' in certain places, whereas other classes have their own private loggers. I'm not really sure how useful this is, but it does appear to be deliberate. CARepeater has both logger and logger2.

It would be very easy to replace all of these with a per-class logger. That seems fairly standard elsewhere. Otherwise we could keep the 'context logger' in Context.java and make it available everywhere with a static method.

@shroffk
Copy link
Contributor Author

shroffk commented Apr 24, 2018

Otherwise we could keep the 'context logger' in Context.java and make it available everywhere with a static method

I was thinking of the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants