-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PvaClientNTMultiMonitor lacks a method to check which channels returned with change after poll #66
Comments
This issue should be resolved with PR #67 |
marciodo's comment is correct. Thanks for raising this issue. After private discussion with sveseli, it was decided that no code change is necessary. I agree that documentation should be better. Marty |
I am going to start work on improving documentation. |
Sinisa Veseli prepared a test case that shows that PvaClientNTMuiliMonitor does not work properly. |
I made changes on branch pvaClientChannel_changes.
I also pushed changes to
It would be great if both of You get a chance to try the new version before I merge the branch into master |
I just took a brief look at the new pvaClientNTMultiData.cpp, and it seems that line 146 will cause the same problem that PR#67 addressed (commit fe74c59). |
I will remove lines 145 and 146. |
I have the impression that, after a poll, I have to examine the contents of the "values" array if I want to check which channels have changed. For the ones that return as none, I know they had no change during the last poll. I would say that this is an indirect and unclear way of checking this. I may be wrong, but I couldn't find this explanation in the documentation.
The text was updated successfully, but these errors were encountered: