Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChartBehaviour methods naming: don't use past tense #19

Open
daattali opened this issue Apr 12, 2021 · 0 comments
Open

ChartBehaviour methods naming: don't use past tense #19

daattali opened this issue Apr 12, 2021 · 0 comments

Comments

@daattali
Copy link
Contributor

Currently there are methods "hostHovered" and "hostUnhovered". It makes it look like this is an event rather than a method. A method is an action you want to make happen, it should be "hostHover"/"hostUnhover"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@daattali