Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No checks for licence URI or typename #43

Open
goetzk opened this issue Jan 8, 2019 · 0 comments
Open

No checks for licence URI or typename #43

goetzk opened this issue Jan 8, 2019 · 0 comments
Milestone

Comments

@goetzk
Copy link
Member

goetzk commented Jan 8, 2019

licenses_uri_* and licenses_typename_* are required for minting to succeed but there is no sanity checking performed within the codebase to ensure they are present (however this fact is mentioned in the README).

                    my $licenseuri = $repo->phrase("licenses_uri_$license");
                    my $licensephrase = $repo->phrase("licenses_typename_$license");

These values should be checked during validation so entries can be fixed rather than having API calls to the DOI provider silently fail.

@goetzk goetzk added this to the v2.2 milestone Jan 8, 2019
@MicheleMorelli MicheleMorelli modified the milestones: v2.2, v2.1 Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants