Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

defer deployed contract address computation to a stage during sync #2074

Open
CHr15F0x opened this issue Jun 13, 2024 · 0 comments · May be fixed by #2414
Open

defer deployed contract address computation to a stage during sync #2074

CHr15F0x opened this issue Jun 13, 2024 · 0 comments · May be fixed by #2414
Assignees
@CHr15F0x
Milestone
P2P sync

Comments

@CHr15F0x
Copy link
Member

Right now TransactionVariant::try_from_dto can trigger deployed contract address computation (literally hashing) depending on transaction type in async context. This should deferred as long as possible to (hopefully) after commitment verification.
@CHr15F0x CHr15F0x self-assigned this Jun 13, 2024
@kkovaacs kkovaacs added this to the P2P sync milestone Jul 19, 2024
@CHr15F0x CHr15F0x removed their assignment Sep 2, 2024
@CHr15F0x CHr15F0x self-assigned this Nov 25, 2024
@CHr15F0x CHr15F0x linked a pull request Nov 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CHr15F0x CHr15F0x

Labels
None yet
Projects
pathfinder
Status: No status
Milestone
P2P sync
Development

Successfully merging a pull request may close this issue.

fix(sync): deployed_contract_address computed in async context eqlabs/pathfinder
2 participants
@kkovaacs @CHr15F0x