fix(sync): deployed_contract_address computed in async context #2414
+120
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbar
approved these changes
Nov 28, 2024
| @@ -441,6 +441,8 @@ impl ToDto<p2p_proto::common::L1DataAvailabilityMode> for L1DataAvailabilityMode | |||
| } | |||
|
|
|||
| impl TryFromDto<p2p_proto::transaction::TransactionVariant> for TransactionVariant { | |||
| /// Caller must take care to compute the contract address for deploy and | |||
| /// deploy account transactions separately is a non-async context. | |||
| @@ -688,6 +678,8 @@ impl TryFromDto<p2p_proto::transaction::TransactionVariant> for TransactionVaria | |||
| } | |||
|
|
|||
| impl TryFromDto<p2p_proto::transaction::Transaction> for Transaction { | |||
| /// Caller must take care to compute the contract address for deploy and | |||
| /// deploy account transactions separately is a non-async context. | |||
sistemd
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2074
A quick test on my pc (ryzen 3700x) shows that
ContractAddress::deployed_contract_addresson average takes > 150us, which is more than the rule of thumb in https://ryhl.io/blog/async-what-is-blocking/ of 10-100us.