Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metal] Plans do not match API spec #65

Closed
ctreatma opened this issue Jun 28, 2024 · 2 comments
Closed

[Metal] Plans do not match API spec #65

ctreatma opened this issue Jun 28, 2024 · 2 comments

Comments

@ctreatma
Copy link
Contributor

Copied from equinix-labs/metal-go#154

The API spec says that the type of a drive in a plan spec must be one of the following:

enum:
- HDD
- SSD
- NVME

However, the API can return the value NVMe, as mentioned in this PR comment from metal-cli: equinix/metal-cli#350 (comment)

The spec needs to be updated so that all possible values for type are documented accurately in the spec.

@ctreatma
Copy link
Contributor Author

In addition to the enum mentioned in the issue description, there are also other enums in the plan spec that do not appear to match all possible plans returned by the Metal API

@ctreatma
Copy link
Contributor Author

ctreatma commented Jul 5, 2024

Fixed by #67 which removed the enums from the Plan schema and was included in v0.42.0.

@ctreatma ctreatma closed this as completed Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant