Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metal-cli brew requires golang #490

Open
e-minguez opened this issue Sep 23, 2024 · 0 comments
Open

metal-cli brew requires golang #490

e-minguez opened this issue Sep 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@e-minguez
Copy link

e-minguez commented Sep 23, 2024

What problem are you facing?

When installing metal-cli via brew it downloads golang as a requisite, however metal-cli is already a binary package, there is no need to build it.

Currently:

❯ brew tap equinix/homebrew-tap
brew install metal-cli
==> Tapping equinix/tap
Cloning into '/opt/homebrew/Library/Taps/equinix/homebrew-tap'...
remote: Enumerating objects: 101, done.
remote: Counting objects: 100% (93/93), done.
remote: Compressing objects: 100% (89/89), done.
remote: Total 101 (delta 56), reused 9 (delta 3), pack-reused 8 (from 1)
Receiving objects: 100% (101/101), 20.48 KiB | 2.28 MiB/s, done.
Resolving deltas: 100% (56/56), done.
Tapped 1 formula (14 files, 30.6KB).
==> Downloading https://formulae.brew.sh/api/formula.jws.json
##################################################################################################################################################################################### 100.0%
==> Downloading https://formulae.brew.sh/api/cask.jws.json
##################################################################################################################################################################################### 100.0%
==> Fetching dependencies for equinix/tap/metal-cli: go
==> Fetching go
==> Downloading https://ghcr.io/v2/homebrew/core/go/manifests/1.23.1
##################################################################################################################################################################################### 100.0%
==> Downloading https://ghcr.io/v2/homebrew/core/go/blobs/sha256:f1d3ecd5e98fd66f0d1a8471b63bfac4508a3b89d2a96c4b2a87243b50866fcd
##################################################################################################################################################################################### 100.0%
==> Fetching equinix/tap/metal-cli
==> Downloading https://github.com/equinix/metal-cli/releases/download/v0.25.0/metal-darwin-arm64
==> Downloading from https://objects.githubusercontent.com/github-production-release-asset-2e65be/134481716/79ee18ef-92d2-4469-97c6-2de5650521c7?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Cred
##################################################################################################################################################################################### 100.0%
==> Installing metal-cli from equinix/tap
==> Installing dependencies for equinix/tap/metal-cli: go
==> Installing equinix/tap/metal-cli dependency: go
==> Downloading https://ghcr.io/v2/homebrew/core/go/manifests/1.23.1
Already downloaded: /Users/eminguez/Library/Caches/Homebrew/downloads/bf6bc8d7da6dd987cd832f8a8ee0c7d90efed8da1cadb9c2270d988af619335a--go-1.23.1.bottle_manifest.json
==> Pouring go--1.23.1.arm64_sonoma.bottle.tar.gz
🍺  /opt/homebrew/Cellar/go/1.23.1: 13,231 files, 268.2MB
==> Installing equinix/tap/metal-cli
🍺  /opt/homebrew/Cellar/metal-cli/0.25.0: 4 files, 20.4MB, built in 1 second
==> Running `brew cleanup metal-cli`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

I uninstalled them (both metal-cli and golang), modified the tap locally to disable the requisite and it works...

So I guess you can remove the dependency? https://github.com/equinix/metal-cli/blob/main/.goreleaser.yml#L47-L49

How could the Equinix Metal CLI help solve this problem?

Modifying the brew tap to disable the golang requisite as the artifact is already a binary.

@e-minguez e-minguez added the enhancement New feature or request label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant