Upgrade pnpm to v8

[wenche]

pnpm v7 is released, and we should look into what it takes to upgrade

[fernandolucchesi]

dependent on #1040

[SvSven]

We now have support for pnpm v7 in the code and GitHub Actions - however we need to resolve how we handle the peer dependencies. What is different in v7 is that the option strict-peer-dependencies is now set to true by default; we can override this by manually setting it to false in .npmrc or by passing it as a flag in the terminal command (which we need to do for GH Actions since we lack a config file there). This works, but is not ideal - better would be to just go over the dependencies and make sure we include what we need (and remove what we don't)

[wenche]

@storybook/addon-docs uses v1.x.x of @mdx-js/react and that version does not support React 18 (version 2 does) See also storybookjs/storybook#18383 for some related discussions. I don't think this is of great importance for us since we are not using mdx

[wenche]

@storybook/addon-essentials -> @storybook/addon-actions -> react-inspector does not yet support React 18

[wenche]

 @storybook/react
│ └─┬ react-element-to-jsx-string
│   ├── ✕ unmet peer react@"^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1": found 18.1.0
│   └── ✕ unmet peer react-dom@"^0.14.8 || ^15.0.1 || ^16.0.0 || ^17.0.1": found 18.1.0

storybookjs/storybook#18349

[wenche]

┬ @equinor/eds-core-react
│ └─┬ @equinor/eds-utils
│   └─┬ react-popper
│     └── ✕ unmet peer react@"^16.8.0 || ^17": found 18.1.0

react-popper v2.30 has fixed this, but the EDS team are holding back the upgrade for React 18 a bit. We don't use any components from EDS that relies on react-popper, so this is not a big deal for us

[wenche]

Forgot to add the one for Reach

No progress on any of the issues yet.

[nilsml]

Why isn't this closed? pnpm is using latest version already

[wenche]

Because we are waiting on updates for all the library mentioned in the comments to get rid of peerDeps warnings

[SvSven]

No official React 18 support for reach-ui yet

[millianapia]

as we are phasing out reach-ui #1378, we can start looking at this again

[fernandolucchesi]

Ready to be worked on after #1532

[nilsml]

pnpm 8 is the latest, so we should upgrade to that version

[SvSven]

According to the migration guide for v8, we need to regenerate the pnpm lockfile as they have upgraded to lockfile version 6, that's missing in the PR still. Should be as simple as making sure your local pnpm version is 8.5.1 similar to the ones pinned in the PR, and then running pnpm setup-project - it'll autoregenerate the lockfiles then - it did for me at least.

Haven't fully tested the web and studio with the new lockfile/pnpm v8 yet though

Also looks like there isn't a Dockerfile in the v3 studio yet, but we'll need that to deploy the satellite studios as well. We can take that in another issue

[SvSven]

Have pushed updated lock files, we should make sure everything still works as expected 😬

[millianapia]

i have checked that the web and studio still works as expected, all of the regular pnpm commands still works. Other things to have in mind before i merge @fernandolucchesi @padms @SvSven ?

[fernandolucchesi]

i have checked that the web and studio still works as expected, all of the regular pnpm commands still works. Other things to have in mind before i merge @fernandolucchesi @padms @SvSven ?

we should test if docker images are also working as expected

[fernandolucchesi]

and dockerfile of sanityv3 should also be updated

[fernandolucchesi]

reviewed sanity v3 docker and works fine! ✅