Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make table height optional #645

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

EdwardBrunton
Copy link
Contributor

Short summary

Make table height optional

Link to issue:
equinor/cc-components#1146

PR Checklist

  • I have performed a self-review of my own code
  • I have written a short summary of my changes in the PR
  • I have linked related issue to the PR
  • I have bumped the version(s) in the changed package(s)
  • I have bumped the version in workspace-fusion

Tip

You can test your changes on the test-application. You can find it under apps\test-app\src\index.tsx

Caution

⛔ I understand by merging my PR, the changed packages will be published to NPM immediately ⛔

Copy link

Howdy, wanderer🌵🤠🐴,

Seems you've sauntered into our GitHub saloon with a pull request, but it appears you've forgotten to tie your horse to the hitching post. Now, in this town, we don't take kindly to stray requests, and the GitHub corral is no place for them.

I reckon you best mosey on over and link that pull request to an issue, lest you want the winds of open source trouble blowin' your way. I've got my eye on you, stranger, and a stern warning echoes through these digital canyons.

Now, for those who might be new to these parts or sufferin' from a bout of forgetfulness, fear not. I've rustled up a guide that's as handy as a snake in a boot🐍🥾. Take a peek at this guide, and it'll show you the way to tether that pull request like a seasoned rancher🤠.

Don't let the sun set on your unlinked pull request, and remember, in these GitHub lands, the code speaks louder than six-shooters.

Sincerely,
The code patrol👮

@Gustav-Eikaas
Copy link
Contributor

Does this work? Previously ag grid needed a height, otherwise it will be 0

Copy link
Contributor

@kjellhaaland kjellhaaland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EdwardBrunton EdwardBrunton added this pull request to the merge queue Oct 18, 2024
@EdwardBrunton EdwardBrunton removed this pull request from the merge queue due to a manual request Oct 18, 2024
@EdwardBrunton EdwardBrunton merged commit bf4aca9 into main Oct 18, 2024
10 checks passed
@EdwardBrunton EdwardBrunton deleted the feat/make-table-height-optional branch October 18, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants