-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing user-user documentation on how to get survey_display_local up and running on the Asus tablet with Kiosk App #4
Comments
The documentation is done. When you get the chance you can review it. Link to wiki repository clone |
I am a bit confused here. Shouldn't the documentation be on this actual project wiki rather than a repository you created called wiki? https://github.com/erdl/survey_display_local/wiki Are you being unable to edit? |
Yeah, I cannot edit the wiki on the actual project. I can't directly make a pull request for the project wiki either. If you give me privileges to edit the wiki, then I should be able to directly add those changes in. |
Actually, sorry you can ignore that comment, I'll add the wiki to my fork of the project and then submit the pull request. |
Hey Ryan, no worries on the wiki for Pull Requests. We only need that for the code! Just add in and I will edit afterward. In fact, I prefer like so in this case since you can't submit "broken documentation", and memory of what you submit is welcomed (just don't go uploading on me credentials or large files haha). |
Ohh! okay got it. Sorry for the confusion. haha So just to clarify: |
lol no, just write directly in the wiki, thats what they are for. You open an issue to indicate a problem, or a new feature you're adding. The solution itself either becomes a code pull request or a wiki entry. You don't need to open an issue for every change you do on the wiki, just major sessions it is worthwhile having here what prompted you to it, and have it linked on both ends. Makes sense? : ) |
k this makes perfect sense now, thanks for clearing that up! Can you give me privileges to add to the wiki in this repository. I'm not able to add new pages or edit existing ones . |
Could you check for me how to do that without giving you edit permissions on the code side as well? : ) This is more of a precaution side to avoid you sending commits without being from Pull Request while trying to commit locally! |
sure, no problem I'll look into it |
I think this may be a solution. In the settings tab of the survey_display_local repo:
Aside from that, I'm not sure how to give access to the wiki without exposing team members to push/write access. |
@ryantanaka nice finding. I set it up. I want you to do two tests:
Ah, and of course try to see if you can do whatever you like with the wiki now! |
Okay, looks good. I tried both. Also, I was able to make a wiki and save it. I'll start moving the appropriate documentation into survey_display_server. task
result:
task
result: |
Alright great! I only did this to the server and the local github, let me know if you need elsewhere! |
continuation from #2
@carlosviansi let me know when have a Wiki up for this project and I'll submit the pull request, thanks!
The text was updated successfully, but these errors were encountered: