Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert test_egauge.py to python notebook #118

Open
matthew-schultz opened this issue Aug 18, 2019 · 0 comments
Open

Convert test_egauge.py to python notebook #118

matthew-schultz opened this issue Aug 18, 2019 · 0 comments
Labels
prio:low

Comments

@matthew-schultz
Copy link
Member

I had initially misunderstood usage of a unit test

  • should be used for code logic only and SHOULD NOT have to update a database

test_egauge assumes there is a database named 'test' and modifies it.
This test would be more fitting in a python notebook where a user could have fields for a database name, etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
prio:low
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthew-schultz