Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent versioning of sensors due to explicit password #11

Open
carlosparadis opened this issue Jan 12, 2019 · 0 comments
Open

Inconsistent versioning of sensors due to explicit password #11

carlosparadis opened this issue Jan 12, 2019 · 0 comments
Labels
wontfix This will not be worked on

Comments

@carlosparadis
Copy link
Member

For future reference,

Versioning configs is currently non viable.

For the frog-uhm project, adding sensors for webctrl for example, requires modifying webctrl-config.toml and value-remap.toml.

According to my guesswork, as the only thing that can be used as guidance here is copy and paste based on other sensors, the webctrl-config.toml defines the names, whereas the value-remap.toml maps it to a purpose id. While I wish I could version them both, webctrl-config.toml, which is not versioned in this repo, contains username and password to the API.

As such, versioning one file and leaving the other up on the server will lead to confusion, at best.

This won't be fixed since the new pipeline is on it's way.

@matthew-schultz here is a clear example of how much bad design can cost us.

@carlosparadis carlosparadis added the wontfix This will not be worked on label Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Development

No branches or pull requests

1 participant