Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Web API: Answer question about hashing to avoid duplicate files. #303

Open
3 of 4 tasks
Tracked by #65
tadhg-ohiggins opened this issue Sep 8, 2016 · 1 comment
Open
3 of 4 tasks
Tracked by #65
Assignees

Comments

@tadhg-ohiggins
Copy link
Contributor

tadhg-ohiggins commented Sep 8, 2016

Currently the Web API creates a hash of an uploaded file, then compares that hash to already-present files, and rejects duplicates.

The idea is that this will prevent users from inadvertently adding the same file multiple times, and help them realize when files that might have different names are actually the same file. (Having confused myself with this mistake when using the parser at the command line is what prompted this feature idea.)

  • Decide whether or not this is actually a good idea.
  • If it is, change hashing from MD5 to SHA256/512 per CM's suggestion.
  • If it is, make the hash key the primary key for the relevant database table.
  • If it isn't, remove the feature.
@tadhg-ohiggins
Copy link
Contributor Author

Addressed in #317

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant