[WIP] Preview fix #1
Conversation
colinrgodsey
changed the base branch from
master
to
base-v2023.03.07-aswb-stable
colinrgodsey
force-pushed
the
colin/previews_fix
branch
3 times, most recently
from
5179035
to
3094cf0
Compare
aswb/src/com/google/idea/blaze/android/projectsystem/DefaultMavenArtifactLocator.java
Show resolved
Hide resolved
aswb/src/com/google/idea/blaze/android/sync/model/idea/BlazeClassJarProvider.java
Outdated
Show resolved
Hide resolved
| @@ -268,4 +309,43 @@ private static VirtualFile getJarRootForLocalFile(VirtualFile file) { | |||
| public static boolean isEnabled() { | |||
| return enabled.getValue(); | |||
| } | |||
|
|
|||
| private class ModuleCache { | |||
There was a problem hiding this comment.
not sure if its worth trying to extend the existing SyncCache pattern
| @@ -24,7 +24,7 @@ | |||
| */ | |||
| public class ExperimentComposeStatusProvider implements ComposeStatusProvider { | |||
| private static final BoolExperiment composeEnabled = | |||
| new BoolExperiment("aswb.force.enable.compose", false); | |||
| new BoolExperiment("aswb.force.enable.compose", true); | |||
There was a problem hiding this comment.
Do we need this? I wasn't actually sure. Someone in the Bazel Slack suggested it, but looking through the codebase, it didn't seem totally necessary. This seemed more of a "last resort".
colinrgodsey
force-pushed
the
colin/previews_fix
branch
2 times, most recently
from
af2f9d5
to
82e90ef
Compare
|
Added a new commit that fixes source code resolution for dependencies (aars and jars) |
(cherry picked from commit d954e3c)
colinrgodsey
force-pushed
the
colin/previews_fix
branch
from
20a1671
to
443c77a
Compare
(cherry picked from commit d954e3c)
|
We are interested in getting this working also. We did some testing, and I am not sure if you are aware but this doesn't render for a constraintlayout when using pinned resources. I created a sample repo to test against and some information related to it. https://github.com/AlexBeggs/sample-constraintlayout-bazel-app |
|
@AlexBeggs ahhh yeah, I noticed that. not really sure where to start with debugging that 🤔 it apparently happens on gradle sometimes, so i wonder if there's some kind of classpath conflict, or possible if intellij is expecting this to be loaded from some specific library instead of the one used in the compiled project? |
|
This is where the If this check is disabled it renders, however I don't know what other side-effects this will cause by removing this check. |
|
ohh thats really interesting! I wonder why that matters.... |
|
so we somehow need the constraintlayout library to pass this filter: |
|
ok wow, I think this definitely unlocked a lot of possibilities here. I think in general something is seriously wrong with the blocking of "generated resources". |
|
alright, so i just found the |
colinrgodsey
changed the base branch from
base-v2023.03.07-aswb-stable
to
base-v2023.03.21-aswb-stable
|
alright, i have a WIP commit on this branch now: 815c76d from what I'm reading about, the blocking of generated resources is for performance reasons, I guess because there was redundant lookup methods? well, guessing one of those redundant methods doesnt work anymore, so unlocking generated resources entirely seems to just fix soooo much. |
|
Thank you for contributing to the IntelliJ repository! This pull request has been marked as stale since it has not had any activity in the last 6 months. It will be closed in the next 14 days unless any other activity occurs or one of the following labels is added: "not stale", "awaiting-review". Please reach out to the triage team ( |
|
This pull request has been automatically closed due to inactivity. If you're still interested in pursuing this, please reach out to the triage team ( |
Fix XML previews, resource resolution, and compose previews.
Fixes: bazelbuild#4046, bazelbuild#2765