Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for --sync.loop.block.limit #10088

Closed
2 tasks
AskAlexSharov opened this issue Apr 27, 2024 · 1 comment
Closed
2 tasks

Better support for --sync.loop.block.limit #10088

AskAlexSharov opened this issue Apr 27, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@AskAlexSharov
Copy link
Collaborator

AskAlexSharov commented Apr 27, 2024

Now if set --sync.loop.block.limit=100:

  • node will download all blocks to db (likely to tmpdb and then copy to db)
  • don't mark blocks as canonical
  • and then will start process them by 100 - only because StageSenders has support for this flag

Need better support for --sync.loop.block.limit because E3 sync speed depends on DB size. And to keep it small - better don't download all blocks.

Read also: #10286 (comment)

  • Do we need support by Caplin? Or it must be only EL feature?
  • To re-visit and simplify updateForkChoice function. In E2 we did revert support of this flag in updateForkChoice. But in E3 we still have (because hard to revert).
@AskAlexSharov AskAlexSharov changed the title Caplin: better support for --sync.loop.block.limit Better support for --sync.loop.block.limit Apr 27, 2024
@yperbasis yperbasis added imp2 Medium importance erigon3 and removed imp2 Medium importance labels May 2, 2024
@AskAlexSharov AskAlexSharov added this to the 3.0.0-alpha1 milestone May 14, 2024
@Giulio2002
Copy link
Contributor

Giulio2002 commented May 14, 2024

Took care of it in: #10341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants