Skip to content
This repository has been archived by the owner on Jan 9, 2024. It is now read-only.

Refactor TraceCallExecutor unit tests #327

Open
canepat opened this issue Jul 22, 2022 · 0 comments
Open

Refactor TraceCallExecutor unit tests #327

canepat opened this issue Jul 22, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@canepat
Copy link
Member

canepat commented Jul 22, 2022

Unit tests for TraceCallExecutor should be refactored to improve readability and semantics:

  • add constructor in EVMExecutor with silkworm::State as input parameter instead of core::rawdb::DatabaseReader
  • add constructor in TraceCallExecutor with silkworm::State and EVMExecutor as input parameters instead of core::rawdb::DatabaseReader or change TraceCallExecutor::execute
  • if possible, refactor EVMExecutor and TraceCallExecutor to avoid templates
  • mock silkworm::State using Gmock
  • refactor unit tests
  • rename TraceCallExecutor as TraceExecutor
@canepat canepat added the enhancement New feature or request label Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant