Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ssh: avoid protocol error on userauth banner #9139

Open
wants to merge 1 commit into
base: maint
Choose a base branch
from
Open

ssh: avoid protocol error on userauth banner #9139

wants to merge 1 commit into from
+82 −2

Conversation

alexandrejbr
Copy link

SSH servers can send userauth banners at any time during authentication and the erlang SSH client only accepted userauth banners in some limited circumstances.

Closes #9065

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

CT Test Results

    2 files     29 suites   17m 58s ⏱️
  463 tests   459 ✅  4 💤 0 ❌
1 668 runs  1 644 ✅ 24 💤 0 ❌

Results for commit 42050aa.

♻️ This comment has been updated with latest results.

To speed up review, make sure that you have read Contributing to Erlang/OTP and that all checks pass.

See the TESTING and DEVELOPMENT HowTo guides for details about how to run test locally.

Artifacts

// Erlang/OTP Github Action Bot

@u3s u3s self-assigned this Dec 4, 2024
@u3s u3s added team:IS Assigned to OTP team IS team:PS Assigned to OTP team PS and removed team:IS Assigned to OTP team IS labels Dec 4, 2024
@u3s
Copy link
Contributor

u3s commented Dec 4, 2024 •
edited
Loading

please use commit tagged with 'OTP-25.3.2' as branch base - so we could use the branch also for making patches on 25, 26. thanks.

@alexandrejbr alexandrejbr force-pushed the alexandrejbr/ssh-accept-userauth-banner branch from f404846 to 49f91ac Compare December 4, 2024 09:32
@alexandrejbr
Copy link
Author

please use commit tagged with 'OTP-25.3.2' as branch base - so we could use the branch also for making patches on 25, 26. thanks.

I have done that now. Should the target branch to merge still be master?

@u3s u3s changed the base branch from master to maint December 4, 2024 09:40
@u3s
Copy link
Contributor

u3s commented Dec 4, 2024

please use commit tagged with 'OTP-25.3.2' as branch base - so we could use the branch also for making patches on 25, 26. thanks.

I have done that now. Should the target branch to merge still be master?

thanks.
I changed it to maint.

@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Dec 4, 2024
@alexandrejbr alexandrejbr mentioned this pull request Dec 5, 2024
Open
@u3s u3s removed the testing currently being tested, tag is used by OTP internal CI label Dec 9, 2024
@alexandrejbr
ssh: avoid protocol error on userauth banner
42050aa 
SSH servers can send userauth banners at any time during authentication
and the erlang SSH client only accepted userauth banners in some limited
circumstances.

Closes erlang#9065
@alexandrejbr alexandrejbr force-pushed the alexandrejbr/ssh-accept-userauth-banner branch from 49f91ac to 42050aa Compare December 10, 2024 10:48
@u3s u3s added the testing currently being tested, tag is used by OTP internal CI label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@u3s u3s

Labels
team:PS Assigned to OTP team PS testing currently being tested, tag is used by OTP internal CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ssh: Receiving SSH_MSG_USERAUTH_BANNER causes a protocol error
2 participants
@alexandrejbr @u3s