Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document image inclusion in espass format #8

Open
4 tasks
eternaltyro opened this issue Oct 1, 2017 · 1 comment
Open
4 tasks

Document image inclusion in espass format #8

eternaltyro opened this issue Oct 1, 2017 · 1 comment

Comments

@eternaltyro
Copy link
Contributor

I downloaded the example passes from espass.it and I noticed that the files named strip.png and footer.png automatically find their places in the pass display when they are included in the container. As far as I can see, this is undocumented in the espass spec. I can help with documentation for this.

Seems to be hardcoded here: https://github.com/ligi/PassAndroid/blob/2eae832bc0ccd6f90b79a0dde9af6d0cfb2f0f4c/android/src/main/java/org/ligi/passandroid/ui/UnzipPassController.kt

  • 1. Types of images that can be included (PNG, SVG?)
  • 2. Name based positioning (strip.png, icon.png, logo.png and footer.png)
  • 3. Dimensions of images in pixels and
  • 4. Max size in kilobytes of each images.

Most of this depends on the passbook application rendering the images. So esPass spec might be agnostic of all of these. I'm not sure though.

Raised the same issue in PassAndroid project too: ligi/PassAndroid#173

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant