Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay navdata conflict #22

Open
wiseman opened this issue Jun 6, 2013 · 3 comments
Open

Replay navdata conflict #22

wiseman opened this issue Jun 6, 2013 · 3 comments

Comments

@wiseman
Copy link
Contributor

wiseman commented Jun 6, 2013

If you use the replay plugin and you're also connected to a real drone, you'll end up with two conflicting sources of navdata events running in parallel:

client.emit('navdata', JSON.parse(data));

io.sockets.emit('navdata', latestNavData);

The observed effect of this is the HUD and any other user interface (or autonomous navigation) based on navdata will jump between two vehicle states.

@eschnou
Copy link
Owner

eschnou commented Jun 9, 2013

Indeed, in my current use case I only use replay when not connected to a drone, for testing purposes. Do you have a use case where you'd like to use replay combined to a real drone? Which data would you like to see preserved then?

@wiseman
Copy link
Contributor Author

wiseman commented Jun 9, 2013

I don't have a use case for it, other than that having to disconnect from the drone before using replay is another step.

@eschnou
Copy link
Owner

eschnou commented Jun 9, 2013

Ok, if we can safely ignore the 'real' client when in replay mode, then forcing a pause() or end() on the client should do the trick. I'll have a look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants