Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeus support #48

Open
asok opened this issue Nov 8, 2012 · 5 comments
Open

Zeus support #48

asok opened this issue Nov 8, 2012 · 5 comments

Comments

@asok
Copy link

asok commented Nov 8, 2012

It would be nice if rinari could support zeus for running scripts and console. Actually it should be easy. You just check if the .zeus.sock file exists in the rails directory. I commited something like this to rails-mode. If you want I can write something similar to rinari.

@purcell
Copy link
Collaborator

purcell commented Nov 8, 2012

Interesting. It looks like:

  • zeus discourages the bundle exec zeus style
  • zeus commands need to be specified in zeus.json
  • zeus needs to be started before running the commands

I'm concerned that it would be harder than you expect to integrate zeus with rinari in a robust way, but I'm happy to consider a patch, so by all means have a look through rinari.el and ruby-compilation and see what you can come up with! :-)

@asok
Copy link
Author

asok commented Nov 8, 2012

I was thinking of something basic:

  • User have setup Zeus (that is ran zeus init in the project root)
  • User starts Zeus in the console with zeus start, by now file .zues.sock is created in the root project
  • emacs checks if file .zeus.sock exists, if yes it runs zeus server instead of rails server, zeus console instead of rails console and so on

@purcell
Copy link
Collaborator

purcell commented Nov 8, 2012

Hey, so I took a look through the code, and it's easy to intercept where "server", "console" and "generate" are run from rinari.el. However, "rake" goes through ruby-compilation.el, and in fact all of the commands eventually call ruby-compilation-do, so that's where the hacking would have to start.

It's a bit fiddly, though, and I'm out of time right now, but I'll come back to this because now I'm also interested in getting it working. :-)

@purcell
Copy link
Collaborator

purcell commented Nov 9, 2012

I should also note (partly for my own benefit) that there is likely to be some confusing behaviour, since rinari allows the user to run, say, "rails console production", but "zeus console" ignores any additional arguments and just runs the command in the development environment.

@asok asok mentioned this issue Nov 10, 2012
@localredhead
Copy link

I would love to assist with Zeus support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants