Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tool lightcurve-analysis to 0.0.1+galaxy0 #91

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

dsavchenko
Copy link
Collaborator

No description provided.

@volodymyrss
Copy link
Contributor

volodymyrss commented Feb 19, 2024

With first commit the default was used instead of input.

With second commit the tool disappeared :(

https://galaxy.odahub.fr/

@dsavchenko could you please have a look?

@dsavchenko
Copy link
Collaborator Author

With second commit the tool disappeared :(

This is some transient problem which I already saw before. The last installed tool may randomly disappear.

Probably, Galaxy requires restarting upon adding the tool (at least, this seemed to help). Currently, I'm injecting tools to the live instance.
I will add the restart to the playbook. It may introduce some minor downtime, but it's not critical here. We can explore how tool registering is happening in Galaxy in more details in the future.

@dsavchenko
Copy link
Collaborator Author

With first commit the default was used instead of input.

This is still the case. I'm having a look

@volodymyrss
Copy link
Contributor

With second commit the tool disappeared :(

This is some transient problem which I already saw before. The last installed tool may randomly disappear.

Probably, Galaxy requires restarting upon adding the tool (at least, this seemed to help). Currently, I'm injecting tools to the live instance. I will add the restart to the playbook. It may introduce some minor downtime, but it's not critical here. We can explore how tool registering is happening in Galaxy in more details in the future.

Ok thanks, the tool is back.

The tool fails somehow, looks like the parameter is not substituted https://galaxy.odahub.fr/datasets/98e8737e708a5bb0/details

@dsavchenko
Copy link
Collaborator Author

The tool fails somehow, looks like the parameter is not substituted

Fixed

@volodymyrss
Copy link
Contributor

volodymyrss commented Feb 19, 2024

This works pretty well!

https://galaxy.odahub.fr/u/volodymyr/w/grb-analysis-workflow

Here I normalize and then combine HESS and SPI-ACS data. It's a of a mock-up of course, I should have started from image or spectra. Or maybe I refine the LC if I find some common variable source, probably the BOAT GRB.

image

edit: here is the file-consuming workflow https://gitlab.renkulab.io/astronomy/mmoda/lightcurve-analysis

Also it's surprisingly fast to propagate the update, maybe a minute or so!

@dsavchenko
Copy link
Collaborator Author

dsavchenko commented Mar 18, 2024

Now using oda-hub/oda-bot#54

@Volodymyr this will pass linting if you add a help and citations
(as well as analogous tools for spectra and image analysis)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants