Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flat config #231

Closed
brettz9 opened this issue Jan 17, 2024 · 7 comments · Fixed by #232
Closed

Flat config #231

brettz9 opened this issue Jan 17, 2024 · 7 comments · Fixed by #232
Assignees
Labels

Comments

@brettz9
Copy link
Contributor

brettz9 commented Jan 17, 2024

Just a request for Flat config support (and ability to stay informed).

@eslintbot eslintbot added this to Triage Jan 17, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in Triage Jan 17, 2024
@nzakas
Copy link
Member

nzakas commented Jan 17, 2024

Sorry, this isn't specific enough. What do you mean by "flat config support"?

@nzakas nzakas moved this from Needs Triage to Triaging in Triage Jan 17, 2024
@brettz9
Copy link
Contributor Author

brettz9 commented Jan 17, 2024

To work as a plugin which can be used as part of the new Flat Config format. Currently, such fields as plugins are expressed in the old format (as an array of strings): https://github.com/eslint/eslint-plugin-markdown/blob/main/lib/index.js#L13

@nzakas
Copy link
Member

nzakas commented Jan 17, 2024

Okay, so what you're talking about is updating the exported configs into flat config format, correct?

Please try to be more specific with requests -- I have a lot of issues to go through. :)

@brettz9
Copy link
Contributor Author

brettz9 commented Jan 17, 2024

yes, thank you

@ghost
Copy link

ghost commented Jan 23, 2024

Yeaeh
This person may have requested the same thing that i miss!! I wanted the readme file to contain a tutorial of how to install your plugin in eslint, now eslint have changed their format from .eslintrc to their so called new flat config.

They detail : https://eslint.org/docs/latest/use/configure/migration-guide

https://eslint.org/blog/2022/08/new-config-system-part-2/

https://eslint.org/blog/2023/10/flat-config-rollout-plans/
https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/

So we would like to request you to please update your readme to allow us to install your plugin in a flat config of eslint, since the current readme doesnt work on it!!
thanks!

@daeh
Copy link

daeh commented Jan 23, 2024

I would also really appreciate instructions on how to set up the plugin for the new ESLint flat config. Many thanks!

@nzakas nzakas self-assigned this Jan 30, 2024
@nzakas
Copy link
Member

nzakas commented Jan 30, 2024

Working on this.

@nzakas nzakas moved this from Ready to Implement to Implementing in Triage Jan 30, 2024
nzakas added a commit that referenced this issue Jan 30, 2024
- Switch recommended config to flat config format
- Rename old recommended config to recommended-legacy
- Updated documentation
- Upgraded ESLint
- Updated tests

fixes #231
nzakas added a commit that referenced this issue Jan 31, 2024
- Switch recommended config to flat config format
- Rename old recommended config to recommended-legacy
- Updated documentation
- Upgraded ESLint
- Updated tests

fixes #231
mdjermanovic added a commit that referenced this issue Feb 15, 2024
* feat!: Switch to flat config

- Switch recommended config to flat config format
- Rename old recommended config to recommended-legacy
- Updated documentation
- Upgraded ESLint
- Updated tests

fixes #231

* Fix linting errors

* Update eslint version

* Fix lint error

* Update ESLint CI installation

* Omit Node.js 12 from CI

* Remove Node.js 14 from CI

* Update README.md

Co-authored-by: Milos Djermanovic <[email protected]>

* Update README.md

Co-authored-by: 唯然 <[email protected]>

* Clean up README

* Update README.md

Co-authored-by: Milos Djermanovic <[email protected]>

* Update README.md

Co-authored-by: Milos Djermanovic <[email protected]>

* Update README.md

Co-authored-by: Milos Djermanovic <[email protected]>

* Update package.json

Co-authored-by: Milos Djermanovic <[email protected]>

* Update package.json

Co-authored-by: Milos Djermanovic <[email protected]>

* Update eslint.config.js

Co-authored-by: Milos Djermanovic <[email protected]>

* Update eslint.config.js

Co-authored-by: Milos Djermanovic <[email protected]>

* Update examples/react/eslint.config.js

Co-authored-by: Milos Djermanovic <[email protected]>

* Update examples/typescript/eslint.config.js

Co-authored-by: Milos Djermanovic <[email protected]>

* Apply feedback

* Update tests/lib/plugin.js

Co-authored-by: Milos Djermanovic <[email protected]>

---------

Co-authored-by: Milos Djermanovic <[email protected]>
Co-authored-by: 唯然 <[email protected]>
@github-project-automation github-project-automation bot moved this from Implementing to Complete in Triage Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants