Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stray ami_ingest_ado_set_SETNUMBER entries in the queue DB #225

Open
DiegoPino opened this issue Dec 22, 2024 · 1 comment
Open

Stray ami_ingest_ado_set_SETNUMBER entries in the queue DB #225

DiegoPino opened this issue Dec 22, 2024 · 1 comment
Assignees
Labels
AMI entity bug Something isn't working CSV Processing Things we do here and there to keep the tabulated goddesses happy Drupal 10 External Bug It is not my fault (anonymous Geologist) Ingest Setup Knobs and Levers you move while thinking about feelings and metadata and CSV files queue FIFO Release duty Things only a mad person should do

Comments

@DiegoPino
Copy link
Member

DiegoPino commented Dec 22, 2024

What?

Looking at space usage i noticed that under certain circumstances, when an AMI is sent to process live but it does not process completely, and then it is sent a second time to the background, the QUEUE database of drupal will keep the oldie/data around and not clear it, even if we are calling
$queue_factory->get($queue_name)->deleteQueue(); in the batch finish process. Sometimes, the batch finish will not actually run (timeouts/failures on the client/etc)

Ideas:

  • Have a cron cleaner for these queues.
  • Have any "process" form submit actually delete the queue upfront *or check if it exists * before enqueueing again.

These tables can grow HUGE. So I will also write an update hook for the next release and document in slack how to clean them manually in the meantime

@DiegoPino DiegoPino added bug Something isn't working queue FIFO Ingest Setup Knobs and Levers you move while thinking about feelings and metadata and CSV files External Bug It is not my fault (anonymous Geologist) Release duty Things only a mad person should do CSV Processing Things we do here and there to keep the tabulated goddesses happy AMI entity Drupal 10 labels Dec 22, 2024
@DiegoPino DiegoPino self-assigned this Dec 22, 2024
@DiegoPino
Copy link
Member Author

Interesting. INNODB tables never actually shrink! So the queue table space keeps being used even after deleting all the entries.

I had to log into MYSQL, and use "optimize table queue" to get the desired effect. This is undocumented in Drupal and something we need to talk about (as a /from time to time practice). I just saved 150 GBytes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AMI entity bug Something isn't working CSV Processing Things we do here and there to keep the tabulated goddesses happy Drupal 10 External Bug It is not my fault (anonymous Geologist) Ingest Setup Knobs and Levers you move while thinking about feelings and metadata and CSV files queue FIFO Release duty Things only a mad person should do
Projects
None yet
Development

No branches or pull requests

1 participant