-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a method for an object link to display a particular page within Mirador #471
Comments
Initial stub of an issue branch based on comments by @DiegoPino on slack: https://github.com/esmero/format_strawberryfield/compare/1.5.0...Born-Digital-US:format_strawberryfield:ISSUE-471?expand=1. I'm really at sea on this and could use some more hints when you have a chance @DiegoPino ! |
@patdunlavey so here is an idea (some code I tried tonight). Mirador has a store. The store is used to keep loaded info, initial Configs etc. Once I have that value (means I parsed from the URL the page) How does that sound? |
Good morning @DiegoPino, thanks for putting eyes and brain on this! Though I fear that your analysis and suggestions for how to do this are mostly over my pointy head! Logging an out-of-bounds index makes sense. Pushing the url state on canvas change sounds great, if not strictly necessary. I really wish I could dive into this and help you by contributing some useful javascript, but I don't see myself being capable of making a dent on this without many, many hours of head-banging. I am willing to put more time into it if you're willing to tutor me on the how's a bit more. But I suspect it would take less of your time to just do it yourself! Let me know if/how you want to proceed on this. |
I'm afraid I haven't gotten very far with this. Well, by restoring and then extending slightly that little block of code that you removed from 1.4.0, I got something working for updating the url to add a hash for the current page (
I'm not sure if that's what you had in mind for that! I have not figured out how to read that hash as Mirador loads and set it to display the corresponding page, however. Just below the part where you add the search query, I tried adding this:
Having gotten the current page parameter, I haven't figured out how to use it to tell Mirador to display that page. |
@patdunlavey give me until Friday. I have a working prototype I can share with you for you to explore/improve and make a proper pull out of it |
That would be awesome! I'll plan to ever-so-gently give you a poke then! |
Yeah, please poke me, bc I have like 4 open pulls I am working at the same time and might forget. Thanks! |
@patdunlavey ping. Did you managed to test the code I shared a few weeks ago? Would love to mark this as solved when you have some time. Thanks |
@DiegoPino I don't think I did! Can you share a link to the branch/PR? |
Use case: a professor wants to discuss a particular item within a creative work series, and shares a link to students that brings up the object display in Mirador that has the canvas corresponding to that item displayed.
For example, perhaps the professor wants students to discuss the signature on this letter, without expecting them to find and click on the thumbnail for the third page:
Anticipated solution is to use a url fragment (the value to the right of the
#
) to identify which page to set Mirador to show when the object page loads. E.g.https://acdc.amherst.edu/view/EdwardOrraWhiteHitchcock/ma00027-02-06-00031#p3
Slack conversation
The text was updated successfully, but these errors were encountered: