Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hydroponics does not update its enabled queues list while already running #259

Open
DiegoPino opened this issue Mar 16, 2023 · 1 comment
Assignees
Labels
bug Something isn't working Configuration Drush $Things that are PHP but run on the Terminal enhancement New feature or request
Milestone

Comments

@DiegoPino
Copy link
Member

DiegoPino commented Mar 16, 2023

What?

Once Hydroponics quicks in Queues marked to be processed by it are read once and used. Any attempt to disable a queue (e.g you know you want to stop processing for a while the background one) will have no effect. That is not ideal.

At least on each Hydroponics round robin (means when it swaps context from one queue to the other) we should re-check what queues are enabled to respect configuration changes

@alliomeria I just noticed this today. While it was running I disabled the Background (OCR) one but OCR kept being executed.

It would be also idea to have a "stop/you did enough" state setting that is not killing Hydroponics but allows it to shutdown gracefully after it finishes one item. Would be ideal that also a "time to live" update could trigger a change. If set to live "0"
means until finish setting 720 should change the scope and allow Hydroponics to shutdown sooner.

Lastly:

  • we should keep track of stats (time per queue item) after each Hydroponics wake up/shutdown cycle and allow that data to be reported to the user in the hydroponics page as stats on each queue listing
  • we should have a config (in case someone gets creative, have seen it) that sets how many Hydroponics services can even run on a server. We don't allow/can/will run more than one, but if you call the drush script manually via an external Service Cron you might have multiple ones. It WON'T HURT if it runs (it was designed to be atomic). Queue items are independent but not every server can ingest/OCR/etc 3 or 4 at the same time without becoming a pile of ashes and black smoke. Just saying.
@DiegoPino DiegoPino self-assigned this Mar 16, 2023
@DiegoPino DiegoPino added bug Something isn't working enhancement New feature or request Configuration Drush $Things that are PHP but run on the Terminal labels Mar 16, 2023
@DiegoPino DiegoPino added this to the 1.1.0 milestone Mar 16, 2023
@DiegoPino DiegoPino changed the title Hydroponics does not update its enabled queue list while already running Hydroponics does not update its enabled queues list while already running Mar 16, 2023
@dmer
Copy link
Collaborator

dmer commented Mar 17, 2023

This is excellent! Super useful tools for repo admins trying to manage large scale ingest/migration. We have been negotiating with Hydroponics a lot in the CAR site - upping the system resources has helped, but I have been wishing for more visibility into what it's doing, when as well as a teeny bit more control over gracefully pausing/stopping things to sort out an issue or allow some other big process to happen. Stats would also help in providing folks with better prediction and better diagnostics.
Pat's away this week, but I will look at this closely w/ him to see if we can think of any other suggestions for this area.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Configuration Drush $Things that are PHP but run on the Terminal enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants