Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the ESMC_Finalize interface to match ESMC_Initialize and add endFlag #257

Open
billsacks opened this issue Jun 14, 2024 · 0 comments
Labels
feature/enhancement New feature or request

Comments

@billsacks
Copy link
Member

This emerges from @oehmke 's comment in PR 234: We want to update the ESMC_Finalize interface to more closely match the ESMC_Initialize interface (e.g., adding *rc and having multiple argument capability). In addition – and this is the connection to #234 – we want to add the new endFlag argument as an optional argument, at which point the new ESMC_FinalizeWithFlag can be removed.

Note that this will involve changing a public interface, which is why we didn't do it with #234.

When making this change, consider bringing the test program from #234 (comment) in as a unit test - or at least running it manually to verify that it still works as intended.

@billsacks billsacks added the feature/enhancement New feature or request label Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant