Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lcd_ev): Upgrade to I2C Driver-NG #444

Merged
merged 1 commit into from
Nov 29, 2024
Merged

feat(lcd_ev): Upgrade to I2C Driver-NG #444

merged 1 commit into from
Nov 29, 2024

Conversation

tore-espressif
Copy link
Collaborator

@tore-espressif tore-espressif commented Nov 28, 2024 •
edited
Loading

Upgrade to I2C Driver-NG

TODO

  • Test audio functions
  • Test all examples
  • Test with 480x480 sub-board

@tore-espressif tore-espressif self-assigned this Nov 28, 2024
@tore-espressif
Copy link
Collaborator Author

@Lzw655 @espzav @pborcin This is an upgrade to I2C Driver-NG for LCD-EV board.

Do you have the 480x480 sub-board? could you please have a look and test?

@espzav
Copy link
Collaborator

espzav commented Nov 29, 2024 •
edited
Loading

480x480 sub-board

Tested on HW "480x480 sub-board" - everything working properly.

  • display_rotation 🆗
  • display_audio_photo 🆗

espzav
espzav approved these changes Nov 29, 2024
View reviewed changes
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tore-espressif Thank you for this PR. LGTM

@tore-espressif tore-espressif merged commit c817af2 into master Nov 29, 2024
18 checks passed
@tore-espressif tore-espressif deleted the feat/lcd_ev_i2c_ng branch November 29, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espzav espzav espzav approved these changes

@Lzw655 Lzw655 Awaiting requested review from Lzw655

@pborcin pborcin Awaiting requested review from pborcin

Assignees

@tore-espressif tore-espressif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tore-espressif @espzav