Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong dependency version (BSP-590) #447

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Conversation

devprofile98
Copy link
Contributor

@devprofile98 devprofile98 commented Dec 1, 2024

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

The add-dependency for esp_lcd_touch_gt911 installs a version that is incompatible with the provided usage example.

esp_lcd_touch_io_gt911_config_t type is defined in version 1.1.1 here , so the 1.0.0 version is not compatible with the example.

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title Wrong dependency version Wrong dependency version (BSP-590) Dec 1, 2024
@tore-espressif
Copy link
Collaborator

@devprofile98 Thank you for the fix!

We will fix the CI and merge

The add-dependency for esp_lcd_touch_gt911 installs a version that is incompatible with the provided usage example. 

esp_lcd_touch_io_gt911_config_t  type is defined in version 1.1.1 so the 1.0.0 version is not compatible with the example.
Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devprofile98 Thank you for this PR. LGTM
Please, could you change the version of the component in YML file to: 1.1.1~2

@tore-espressif
Copy link
Collaborator

@devprofile98 Thank you for this PR. LGTM Please, could you change the version of the component in YML file to: 1.1.1~2

@espzav maybe not needed for README.md change?

@devprofile98
Copy link
Contributor Author

@espzav Done.

@espzav
Copy link
Collaborator

espzav commented Dec 3, 2024

@devprofile98 Thank you for this PR. LGTM Please, could you change the version of the component in YML file to: 1.1.1~2

@espzav maybe not needed for README.md change?

@tore-espressif I was thinking about it, but it wouldn't be released to component manager without version changed and we do not plan make any updates in this component now for release it soon.

@espzav espzav merged commit 7969b01 into espressif:master Dec 3, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants