-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong dependency version (BSP-590) #447
Conversation
@devprofile98 Thank you for the fix! We will fix the CI and merge |
The add-dependency for esp_lcd_touch_gt911 installs a version that is incompatible with the provided usage example. esp_lcd_touch_io_gt911_config_t type is defined in version 1.1.1 so the 1.0.0 version is not compatible with the example.
f0878ce
to
273e163
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devprofile98 Thank you for this PR. LGTM
Please, could you change the version of the component in YML file to: 1.1.1~2
@espzav maybe not needed for README.md change? |
@espzav Done. |
@tore-espressif I was thinking about it, but it wouldn't be released to component manager without version changed and we do not plan make any updates in this component now for release it soon. |
ESP-BSP Pull Request checklist
Change description
The add-dependency for esp_lcd_touch_gt911 installs a version that is incompatible with the provided usage example.
esp_lcd_touch_io_gt911_config_t type is defined in version 1.1.1 here , so the 1.0.0 version is not compatible with the example.