fix(modem): Refactor of DTE callbacks (and other fixes) #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
david-cermak
force-pushed
the
fix/minor_modem_refactor
branch
from
3387680 to
4652526
Compare
diplfranzhoepfinger
pushed a commit
to diplfranzhoepfinger/esp-protocols-tree-master-components-esp_modem-examples-simple_cmux_client
that referenced
this pull request
Jul 18, 2023
3 tasks
3 tasks
euripedesrocha
approved these changes
Aug 17, 2023
david-cermak
force-pushed
the
fix/minor_modem_refactor
branch
from
4652526 to
22da99a
Compare
|
Thanks for the review @euripedesrocha ! |
david-cermak
force-pushed
the
fix/minor_modem_refactor
branch
from
22da99a to
db9f3f3
Compare
david-cermak
force-pushed
the
fix/minor_modem_refactor
branch
from
db9f3f3 to
ad8bb62
Compare
As a configurable option, if disabled we report an error. Closes espressif#272
Removes PPP_started signal on reception, since lwip handles data reception if the netif is up/down (which we correctly set in start() stop() methods) Closes espressif#308
This allows calling directly:
auto dce = dce_factory::Factory::create_unique_dce_from<SIM7600>(&dce_config, uart_dte, esp_netif);
instead of:
auto dce = create_SIM7600_dce(&dce_config, uart_dte, esp_netif);
Which is very useful when adding a custom module, so we won't need to
update factory layers and add the new device to enums, etc.
To add a new module, you just:
1) Define the module class NewModule: public GenericModule { };
2) Implement the specific commands:
command_result do_work_new_module(CommandableIf *t, params) {}
3) Connect 1) and 2)
command_result NewModule::do_work_new_module(params...)
{
return dce_commands::do_work_new_module(dte.get(), params...);
}
david-cermak
force-pushed
the
fix/minor_modem_refactor
branch
from
ad8bb62 to
4cf9e50
Compare
|
@david-cermak This change is breaking DUAL_MODE for USB modems. Is there any reason why the DTE constructor cannot initialize DUAL_MODE anyomore? cb6e03a#diff-d13893478ad7bd229158ba84355f1d361f2afd680a28605a304de8945280ce0d Related issue espressif/idf-extra-components#249 |
Oh, I missed that. This really is just a copy-paste error. I'll fix it. It seems we really need at least one CI runner with a USB device. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO