Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(modem): Refactor of DTE callbacks (and other fixes) #312

Merged
merged 3 commits into from
Aug 28, 2023
Merged

fix(modem): Refactor of DTE callbacks (and other fixes) #312

merged 3 commits into from
Aug 28, 2023

Commits on Aug 28, 2023

  1. fix(modem): Added support for inflatable buffer 

    As a configurable option, if disabled we report an error.

Closes espressif#272
    @david-cermak
    david-cermak committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    cb6e03a View commit details
    Browse the repository at this point in the history

  2. fix(modem): Fix netif data race causing PPP startup delays 

    Removes PPP_started signal on reception, since lwip handles data
reception if the netif is up/down (which we correctly set in start()
stop() methods)

Closes espressif#308
    @david-cermak
    david-cermak committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    c8c0507 View commit details
    Browse the repository at this point in the history

  3. feat(modem): Add factory method for simple creation of custom DCEs 

    This allows calling directly:
auto dce = dce_factory::Factory::create_unique_dce_from<SIM7600>(&dce_config, uart_dte, esp_netif);
instead of:
auto dce = create_SIM7600_dce(&dce_config, uart_dte, esp_netif);
Which is very useful when adding a custom module, so we won't need to
update factory layers and add the new device to enums, etc.
To add a new module, you just:
1) Define the module class NewModule: public GenericModule { };
2) Implement the specific commands:
command_result do_work_new_module(CommandableIf *t, params) {}
3) Connect 1) and 2)
command_result NewModule::do_work_new_module(params...)
{
    return dce_commands::do_work_new_module(dte.get(), params...);
}
    @david-cermak
    david-cermak committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    4cf9e50 View commit details
    Browse the repository at this point in the history