ci: update .yml file test report ui #811
Conversation
AndriiFilippov
force-pushed
the
IEP-1008
branch
from
dfcd29c to
1bb305b
Compare
WalkthroughThis update modifies the CI/CD pipeline for Windows, replacing the previous test reporting action with a new one. The new action provides more configuration options and uses the Changes
TipsChat with CodeRabbit Bot (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments generated: 1
Files selected for processing (1)
- .github/workflows/ci_windows.yml (1 hunks)
Additional comments (Suppressed): 1
.github/workflows/ci_windows.yml (1)
- 48-53: The old test reporting action
scacap/action-surefire-report@v1has been commented out. If this is intentional and the new actionphoenix-actions/test-reporting@v12is meant to replace it entirely, please ensure that the new action provides all the necessary functionality and meets the project's requirements.
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Tag the bot with
@coderabbitaiin any review comment to ask it questions. The bot will not respond unless explicitly tagged. - A review comment is a comment on a diff or a file and not a comment on the PR itself.
- You can use the mouse to select multiple lines of code to provide exact context to the bot.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
.github/workflows/ci_windows.yml
Outdated
| - name: Test Reporting1 | ||
| if: ${{ always() }} | ||
| uses: scacap/action-surefire-report@v1 | ||
| uses: phoenix-actions/test-reporting@v12 | ||
| with: | ||
| check_name: 'Windows Test Reports' | ||
| name: Test Results | ||
| path: | | ||
| tests/com.espressif.idf.ui.test/target/surefire-reports/*.xml | ||
| tests/com.espressif.idf.core.test/target/surefire-reports/*.xml | ||
| reporter: java-junit |
There was a problem hiding this comment.
The new test reporting action phoenix-actions/test-reporting@v12 has been added. Please make sure that the paths specified in line 59-61 are correct and contain the test reports generated by the Maven build. Also, verify that the reporter 'java-junit' is compatible with the format of your test results.
- name: Test Reporting1
+ name: Test ReportingThe name of the step should be more descriptive and professional. Consider changing it from 'Test Reporting1' to 'Test Reporting'.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Files selected for processing (1)
- .github/workflows/ci_windows.yml (1 hunks)
Additional comments (Suppressed): 2
.github/workflows/ci_windows.yml (2)
45-46: The build step remains unchanged and looks good.
48-52: The old test reporting step has been commented out. Ensure that the new test reporting action covers all the functionalities of the old one.
.github/workflows/ci_windows.yml
Outdated
| - name: Test Reporting1 | ||
| if: ${{ always() }} | ||
| uses: scacap/action-surefire-report@v1 | ||
| uses: phoenix-actions/test-reporting@v12 | ||
| with: | ||
| check_name: 'Windows Test Reports' | ||
| name: Test Results Report | ||
| path: | ||
| tests/*/*/*/TEST-*.xml | ||
| reporter: java-junit |
There was a problem hiding this comment.
The new test reporting step uses the phoenix-actions/test-reporting action. The configuration seems correct, but ensure that the path tests/*/*/*/TEST-*.xml correctly points to the location of the test result files in your project structure.
- path:
- tests/*/*/*/TEST-*.xml
+ path: 'path/to/your/test/results/*.xml'Also, verify that the reporter java-junit is compatible with the format of your test results.
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Files selected for processing (1)
- .github/workflows/ci_windows.yml (1 hunks)
Additional comments (Suppressed): 2
.github/workflows/ci_windows.yml (2)
45-46: The build step remains unchanged and looks good.
48-52: The old test reporting action
scacap/action-surefire-report@v1has been commented out. Ensure that the new actionphoenix-actions/test-reporting@v12provides all the necessary features and is compatible with the project's requirements.
AndriiFilippov
force-pushed
the
IEP-1008
branch
from
5a6093e to
0621ed6
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Files selected for processing (1)
- .github/workflows/ci_windows.yml (1 hunks)
Additional comments (Suppressed): 2
.github/workflows/ci_windows.yml (2)
45-46: The Maven build command remains unchanged and should work as expected.
48-52: The old test reporting step has been commented out. Ensure that the new test reporting action
phoenix-actions/test-reporting@v12provides equivalent or better functionality than the previous onescacap/action-surefire-report@v1.
.github/workflows/ci_windows.yml
Outdated
| - name: Test Reporting1 | ||
| if: ${{ always() }} | ||
| uses: scacap/action-surefire-report@v1 | ||
| uses: phoenix-actions/test-reporting@v12 | ||
| with: | ||
| check_name: 'Windows Test Reports' | ||
| name: Windows Test Reports | ||
| path: | ||
| tests/*/*/*/TEST-*.xml | ||
| reporter: java-junit |
There was a problem hiding this comment.
The new test reporting step uses the phoenix-actions/test-reporting@v12 action. The if: ${{ always() }} condition ensures that this step will always run, regardless of the success or failure of previous steps, which is good for catching all test results.
However, there's a minor indentation issue on line 56 which could cause a YAML parsing error. Here's the corrected version:
- name: Test Reporting1
if: ${{ always() }}
uses: phoenix-actions/test-reporting@v12
uses: phoenix-actions/test-reporting@v12
with:
name: Windows Test Reports
path:
tests/*/*/*/TEST-*.xml
reporter: java-junit
AndriiFilippov
force-pushed
the
IEP-1008
branch
from
5162d68 to
6c6f5f8
Compare
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- .github/workflows/ci_windows.yml (1 hunks)
Additional comments (Suppressed): 3
.github/workflows/ci_windows.yml (3)
47-55: The new action
phoenix-actions/test-reporting@v12is being used to publish test reports. Ensure that this action is compatible with the project's testing framework and that it can correctly interpret the XML files generated by the tests. Also, verify that the pathtests/*/*/*/TEST-*.xmlcorrectly points to the location of the test result XML files in your project structure.49-49: The condition
if: ${{ always() }}means that this step will always run, even if previous steps fail. This is generally a good practice for test reporting steps, as you often want to see test results even if other parts of the workflow fail. However, ensure that this is the desired behavior in your specific context.51-55: The configuration options for the new action have been set appropriately. The
namefield has been set to 'Windows Test Reports', thepathfield points to the location of the test result XML files, and thereporterfield has been set to 'java-junit', which is appropriate for a Java project using JUnit for testing.
Description
Prepare Test Reports for Espressif-IDE
IEP-1008
Type of change
Please delete options that are not relevant.
How has this been tested?
Check CI Test Report
Test Configuration:
Checklist
Summary by CodeRabbit
phoenix-actions/test-reportingto enhance test reporting capabilities. This new action provides more configuration options, including the ability to specify the name of the test reports, the path to the XML files containing the test results, and the reporter type.