Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for WS2811 timing (IEC-194) #402

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Conversation

sterisa
Copy link
Contributor

@sterisa sterisa commented Oct 13, 2024

Change description

Within the led_strips component:
Added a new led model in led_strip_types
Added the corresponding timing in led_strip_rmt_encoder (I had to move reset_ticks definition up to be able to edit it for WS2811

Source: https://cdn-shop.adafruit.com/datasheets/WS2811.pdf
or https://www.alldatasheet.com/datasheet-pdf/view/1132633/WORLDSEMI/WS2811.html

I tested on a WS2811 50 led strip
Note WS2811 is RGB, not GRB. I will put that change in later

@CLAassistant
Copy link

CLAassistant commented Oct 13, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the title add support for WS2811 timing add support for WS2811 timing (IEC-194) Oct 13, 2024
@suda-morris
Copy link
Collaborator

@sterisa Thanks for your contribution. This PR proposed a new way to set the pixel order in the user code, I think it can also help with your WS2811: #344

@sterisa
Copy link
Contributor Author

sterisa commented Oct 23, 2024

@sterisa Thanks for your contribution. This PR proposed a new way to set the pixel order in the user code, I think it can also help with your WS2811: #344

A little overkill, but I am fine whatever you decide. My WS2811 timing changes are pretty small and independent of the RGB vs GRB handling. Should I revert my RGB changes?

@suda-morris
Copy link
Collaborator

Hi @sterisa Thanks for your time! #344 just got merged. Now it should be possible to support any R/G/B/W order.

The timing configuration of WS2811 in this PR is still valuable. Could you please rebase your branch and fix the conflict?

@sterisa
Copy link
Contributor Author

sterisa commented Oct 26, 2024

Hi @sterisa Thanks for your time! #344 just got merged. Now it should be possible to support any R/G/B/W order.

The timing configuration of WS2811 in this PR is still valuable. Could you please rebase your branch and fix the conflict?

Done, this should be the minimal change for the WS2811 timing

@suda-morris suda-morris merged commit ca95694 into espressif:master Oct 27, 2024
48 checks passed
@sterisa sterisa deleted the WS2811 branch October 28, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants