Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QEMU support for NuttX service (RDT-1034) #322

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

fdcavalcanti
Copy link
Contributor

Description

This PR improves the Nuttx service by adding support for QEMU.
It also modifies the reset functionality to support serial reset (DTR toggle), QEMU reset and ESP reset.
On a different topic, there's a smaller commit to improve logging on app binary search.

Related

None.

Testing

Tested locally running qemu applications.


Looking forward to any improvements.

Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR.

Besides, could you also update the optional dependency qemu here?

[project.optional-dependencies]

and here with the optional qemu service?

pytest-embedded-nuttx -->|optional, support test on espressif chips| pytest-embedded-serial-esp

pytest-embedded-nuttx/pytest_embedded_nuttx/__init__.py Outdated Show resolved Hide resolved
pytest-embedded-nuttx/pytest_embedded_nuttx/dut.py Outdated Show resolved Hide resolved
@fdcavalcanti
Copy link
Contributor Author

@hfudev Modifications done. Also added few changes on documentation regarding qemu.

@github-actions github-actions bot changed the title Add QEMU support for NuttX service Add QEMU support for NuttX service (RDT-1034) Nov 26, 2024
@hfudev hfudev merged commit a00dffe into espressif:main Nov 27, 2024
4 of 5 checks passed
@hfudev
Copy link
Member

hfudev commented Nov 27, 2024

LGTM. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants