Merge pull request #3682 from bobrippling/feat/promenu-remove

promenu: call `options.remove` when removed
espruino · Dec 11, 2024 · f964405 · f964405
2 parents 516b74f + 9987a2d
commit f964405
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 1 deletion.
diff --git a/apps/promenu/ChangeLog b/apps/promenu/ChangeLog
@@ -11,3 +11,4 @@
 0.07: Fix bug with alarms app (scroller) and correctly show images
 0.08: Fix bug with modifying menu - allows hadash to save scroll positions
 0.09: Don't show "..." if a string isn't truncated (i.e. scrolled)
+0.10: Trigger `remove` callbacks when ending the menu
diff --git a/apps/promenu/bootb2.js b/apps/promenu/bootb2.js
@@ -193,9 +193,11 @@ E.showMenu = function (items) {
         mode: "updown",
         back: back,
         remove: function () {
+            var _a;
             if (nameScroller)
                 clearInterval(nameScroller);
             Bangle.removeListener("swipe", onSwipe);
+            (_a = options.remove) === null || _a === void 0 ? void 0 : _a.call(options);
         },
     }, function (dir) {
         if (dir)

diff --git a/apps/promenu/bootb2.ts b/apps/promenu/bootb2.ts
@@ -240,6 +240,7 @@ E.showMenu = (items?: Menu): MenuInstance => {
     remove: () => {
       if (nameScroller) clearInterval(nameScroller);
       Bangle.removeListener("swipe", onSwipe);
+      options.remove?.();
     },
   } as SetUIArg<"updown">,
   dir => {

diff --git a/apps/promenu/metadata.json b/apps/promenu/metadata.json
@@ -1,7 +1,7 @@
 {
   "id": "promenu",
   "name": "Pro Menu",
-  "version": "0.09",
+  "version": "0.10",
   "description": "Replace the built in menu function. Supports Bangle.js 1 and Bangle.js 2.",
   "icon": "icon.png",
   "type": "bootloader",