Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rebbleagenda, pebble-like animated agenda. #2995

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

SarahAlroe
Copy link
Contributor

Hi there,
I've been working on an agenda viewer inspired by the pebble time interface.
This first version allows for swiping through calendar events with markers separating days.

New here, so do say if I've missed something :)

@gfwilliams
Copy link
Member

This looks great - thanks!

@gfwilliams gfwilliams merged commit e2d8a23 into espruino:master Sep 4, 2023
1 check passed
@thyttan
Copy link
Collaborator

thyttan commented Sep 5, 2023

Yes, I think this is super cool as well!

I had some weirdness with hidden widgets that when hiding would draw background colour over the side bar.

Also, the App Loader should probably ask what to do if another agenda is already installed (Replace/Cancel/Keep both), like it does for e.g. keyboards. Especially since the shortName of rebbleagenda is the same as agenda's name so the settings pages interfere.

Again, cool!

edit: I mentioned Rebble Agenda on the forum's App ideas converation.

@gfwilliams
Copy link
Member

the App Loader should probably ask what to do if another agenda is already installed

Yes - I think that's something we would need to figure out rather than @SarahAlroe, but it should be possible (even if a bit of a hack) by adding "provides_widgets" : ["agenda"] to both of them

@SarahAlroe
Copy link
Contributor Author

I had some weirdness with hidden widgets that when hiding would draw background colour over the side bar.

I do get some weird widget stuff at the last frame of closing the app (which I believe is unavoidable), but otherwise not.
@thyttan Do you have an application list or idea of possible co-culprit so I can replicate?
I have a suspicion it's because I load widgets pretty late, but would be nice to verify :)

it should be possible (even if a bit of a hack) by adding "provides_widgets" : ["agenda"] to both of them

I think that could become pretty confusing for people who are not aware of the issue, especially if someone starts making agenda widgets, whatever that would be. Adding some sort of "mutually_exclusive_group" property might be less confusing, but would complicate the metadata further so maybe not a great idea either.
For a very easy short term fix, we could just change the shortname to something else?

@thyttan
Copy link
Collaborator

thyttan commented Sep 6, 2023

Do you have an application list or idea of possible co-culprit so I can replicate?
I have a suspicion it's because I load widgets pretty late, but would be nice to verify :)

Yes - thanks, the main problem I just realized is I have Fastload Utils installed (which I should have thought of immediately - gotta be better at remembering that >.< ). So with that uninstalled the problem goes away. I'd imagine if you want to try installing Fastload Utils you'll see the weirdness, provided you have some widgets that usually sit to the right in the widget field. But don't feel you have to accommodate it, Fastload Utils is explicitly experimental. I can post my installed apps if you still want.

@SarahAlroe
Copy link
Contributor Author

I'd imagine if you want to try installing Fastload Utils you'll see the weirdness

Yup, I see it, thanks :)
Changing the drawing order seems to fix it.
I will include the change next time I make a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants