Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

locale: Remove meridians from time patterns #3575

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

atjn
Copy link
Contributor

@atjn atjn commented Sep 16, 2024

Related to #3534

These formatting symbols are not used, and they should not be used because most apps only work with the time string HH:MM:SS and they expect the meridian to be accessible from the separate meridian function. I suggest removing these symbols.

The removal changes nothing for existing users of the app.

@atjn
Copy link
Contributor Author

atjn commented Sep 16, 2024

Requesting review from @gfwilliams

@gfwilliams gfwilliams merged commit 4689f45 into espruino:master Sep 24, 2024
1 check passed
@atjn atjn deleted the remove-meridians branch September 24, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants