andark: Restore redraw on charging and small fixups #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buzden
changed the title
thyttan
reviewed
Dec 11, 2024
buzden
force-pushed
the
fixup-andark-on-charging
branch
from
973189c to
8ebd66d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #3678 removed immediate redrawing on charging, which is inconvenient, since when you connect the charger, watches may be locked and thus not redrawing, not showing the charging status. Additionally, I did a small correction regarding to the cleanup order to make fast loading work well, since one timeout was removed before a callback that could reset it again. Also, I did some (I hope) reasonable refactoring. I did all in separate commits to make the review easier.