E_showMenu_/E_showScroller_Q3: forward touch event #2565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thyttan
commented
Oct 8, 2024
thyttan
force-pushed
the
showscroller-q3
branch
2 times, most recently
from
eea6182 to
2f4f710
Compare
gfwilliams
reviewed
Oct 8, 2024
|
Thanks - looks good - I think it's just that comment? |
thyttan
commented
Oct 8, 2024
thyttan
force-pushed
the
showscroller-q3
branch
from
206a4fd to
09096dd
Compare
gfwilliams
reviewed
Oct 9, 2024
|
Thanks for that PR - just merged! So I guess we just need to remove |
The goal was to make it possible for menus to distinguish between short and long touches when the entry maps to a function. With this alarms in the `alarm` app could be made togglable by longpressing corresponding menu entries.
thyttan
force-pushed
the
showscroller-q3
branch
from
09096dd to
54f631d
Compare
|
Yes I think so too! I did the changes so should be merge ready. |
|
Thanks! |
gfwilliams
added a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal was to make it possible for menus to distinguish between short
and long touches when the entry maps to a function.
With this alarms in the
alarmapp could be made togglable by longpressingcorresponding menu entries.
Complements espruino/BangleApps#3604