Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RawConfig serializeable #382

Open
Creative-Difficulty opened this issue Jul 14, 2024 · 11 comments
Open

Make RawConfig serializeable #382

Creative-Difficulty opened this issue Jul 14, 2024 · 11 comments

Comments

@Creative-Difficulty
Copy link

I'm serializing RawConfig into TOML in my CLI and for my tests (and also to be able to construct RawConfig programmatically) it is neccesary to serialize RawConfig into a string. Some other issues have been opened about this, so I think the community is interested. This would greatly benefit many projects and I don't think it would require much work for the library. I'm currently considering opening a PR myself.
@estk

@Creative-Difficulty
Copy link
Author

Also: My (and a lot of peoples) config struct incorporates RawConfig, so not being able to serialize it makes the whole config struct unserializeable.

@Creative-Difficulty
Copy link
Author

Creative-Difficulty commented Jul 16, 2024

@bconn98
Copy link
Collaborator

bconn98 commented Jul 16, 2024

@Creative-Difficulty Can you point to those other requests? Just not sure I've seen them.

@Creative-Difficulty
Copy link
Author

@bconn98 #383

@Creative-Difficulty
Copy link
Author

pr i opened

@bconn98
Copy link
Collaborator

bconn98 commented Jul 16, 2024

@Creative-Difficulty Yup I saw that PR. I was talking about the comment you made (see below).

Some other issues have been opened about this, so I think the community is interested

I just wanted to take a look at the other requests.

@bconn98
Copy link
Collaborator

bconn98 commented Jul 17, 2024

I'm also curious about how your changes support the following:

and also to be able to construct RawConfig programmatically

@Creative-Difficulty
Copy link
Author

Creative-Difficulty commented Jul 17, 2024

I'm also curious about how your changes support the following:

and also to be able to construct RawConfig programmatically

Thats another issue, however now i can deserialize it from a string, modify some properties and serialize it back. So at the moment it's just programmatic modification, which really helps with tests.

@bconn98
Copy link
Collaborator

bconn98 commented Jul 22, 2024

@Creative-Difficulty Yup I saw that PR. I was talking about the comment you made (see below).

Some other issues have been opened about this, so I think the community is interested

I just wanted to take a look at the other requests.

@Creative-Difficulty any updates on this?

@Creative-Difficulty
Copy link
Author

@bconn98 Sorry for the late response, this is what i found:
#270
#70

@bconn98
Copy link
Collaborator

bconn98 commented Aug 2, 2024

@Creative-Difficulty I don't believe either of these are requesting for the RawConfig to be made serializable. However, I'll take a look since it appears to largely be auto generated code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants