Skip to content

Commit

Permalink
agent: temporarily disable periodic publications so we can deploy
Browse files Browse the repository at this point in the history
  • Loading branch information
psFried committed Dec 12, 2024
1 parent c8fda98 commit b6a2ea9
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
16 changes: 9 additions & 7 deletions crates/agent/src/controllers/periodic.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,14 @@ pub fn start_periodic_publish_update<C: ControlPlane>(
pending
}

// TODO: periodic publications are temporarily disabled
fn is_spec_disabled(state: &ControllerState) -> bool {
state
.live_spec
.as_ref()
// Collections are never considered disabled, since they can still be
// captured or materialized even if derivation shards are disabled.
.map(|ls| ls.catalog_type() != models::CatalogType::Collection && !ls.is_enabled())
.unwrap_or(true)
true
// state
// .live_spec
// .as_ref()
// // Collections are never considered disabled, since they can still be
// // captured or materialized even if derivation shards are disabled.
// .map(|ls| ls.catalog_type() != models::CatalogType::Collection && !ls.is_enabled())
// .unwrap_or(true)
}
4 changes: 4 additions & 0 deletions crates/agent/src/integration_tests/periodic_publications.rs
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
use std::collections::BTreeSet;

// TODO: temporarily disabled
/*
use crate::{
controllers::{ControllerState, Status},
integration_tests::harness::{
Expand Down Expand Up @@ -182,3 +184,5 @@ async fn specs_are_published_periodically() {
disabled_cap_end.last_build_id
);
}
*/

0 comments on commit b6a2ea9

Please sign in to comment.