-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create gitlab.md #1171
Create gitlab.md #1171
Conversation
Adding docs for Gitlab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with a few suggestions inline!
You configure connectors either in the Flow web app, or by directly editing the catalog specification file. | ||
See [connectors](../../../concepts/connectors.md#using-connectors) to learn more about using connectors. The values and specification sample below provide configuration details specific to the GitHub source connector. | ||
|
||
### Setup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the past when I've included a Setup section, it was intended as steps to meet the prerequisites... if the prerequisites aren't self-explanatory. (Hence why some of our connector docs have prereqs but no setup steps listed). This totally works too but just FYI.
|
||
### Using OAuth2 to authenticate with GitLab in the Flow web app | ||
|
||
* A GitLab user account with access to the repositories of interest, and which is a member of organizations of interest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth noting what role/permissions specifically are required for this to work (https://docs.gitlab.com/ee/user/permissions.html). Also I'd recommend linking to their docs on how to add a member to an org - https://docs.gitlab.com/ee/user/project/members/#add-users-to-a-project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed these
|
Adding docs for Gitlab
This change is