assemble: add numeric information to inference #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamhbaker
force-pushed
the
wb/numeric-inference-added
branch
from
595987e to
4c2f569
Compare
Includes the "numeric" information in projection inference if it is available.
williamhbaker
force-pushed
the
wb/numeric-inference-added
branch
from
4c2f569 to
409571a
Compare
|
Forgot to change this out of draft status, but it is indeed ready for review. At one point I had considered adding some kind of precise indication for when the number bound exceed a maximum i64 since that is a threshold many connectors care about, but the transmission of that value via a floating point caused inconsistencies when trying to interpret it on the connector's side so I held off on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a follow-up to #1554 and #1564. We will now include the
numericinference information in builds, and it will be available to connectors.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is