protocols/flow: add array inference to protocol #1787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds "array" information to projection inference, which will include the types of items the array contains, as well as the minimum and maximum number of items it is allowed to contain. This is only adding the (optional) field to the protocol. All users of the updated rust structs will need to be updated to use the new structs before the new field is populated. Things that will need updated to use the updated rust structs include: - `derive-typescript` - Rust connectors: `source-kafka` and `source-http-ingest` - dekaf - flowctl, with gitpod implications - ATF
williamhbaker
force-pushed
the
wb/array-inference
branch
from
891abf9 to
1555a3a
Compare
|
Noting we'll also want to update this pin: https://github.com/estuary/flow/blob/master/crates/runtime/src/container.rs#L21 (It's used for the flow-connector-init binary by flowctl if it can't otherwise locate one) |
williamhbaker
added a commit
to estuary/airbyte
that referenced
this pull request
Dec 11, 2024
Updates ATF to the latest Flow protocol from estuary/flow#1787, which includes information about array fields in projection inference.
williamhbaker
added a commit
to estuary/connectors
that referenced
this pull request
Dec 11, 2024
Updates the Flow protocol pin for rust connectors to include array information in projection inference, per the changes in estuary/flow#1787.
williamhbaker
added a commit
to estuary/connectors
that referenced
this pull request
Dec 12, 2024
Updates the Flow protocol pin for rust connectors to include array information in projection inference, per the changes in estuary/flow#1787.
williamhbaker
added a commit
to estuary/connectors
that referenced
this pull request
Dec 12, 2024
Updates the Flow protocol pin for rust connectors to include array information in projection inference, per the changes in estuary/flow#1787.
github-actions bot
pushed a commit
to estuary/homebrew-flowctl
that referenced
this pull request
Dec 12, 2024
## What's Changed * flowctl: use new view_logs RPC with logged_at bound estuary/flow#1739 * flowctl raw bearer-logs: add --since parameter with 1 hour default estuary/flow#1752 * flowctl: add `raw spec` support for materializations estuary/flow#1798 * protocols/flow: add array inference to protocol estuary/flow#1787 **Full Changelog**: estuary/flow@v0.5.7...v0.5.8
williamhbaker
added a commit
to estuary/homebrew-flowctl
that referenced
this pull request
Dec 12, 2024
## What's Changed * flowctl: use new view_logs RPC with logged_at bound estuary/flow#1739 * flowctl raw bearer-logs: add --since parameter with 1 hour default estuary/flow#1752 * flowctl: add `raw spec` support for materializations estuary/flow#1798 * protocols/flow: add array inference to protocol estuary/flow#1787 **Full Changelog**: estuary/flow@v0.5.7...v0.5.8
williamhbaker
added a commit
to estuary/airbyte
that referenced
this pull request
Dec 12, 2024
Updates ATF to the latest Flow protocol from estuary/flow#1787, which includes information about array fields in projection inference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds "array" information to projection inference, which will include the types of items the array contains, as well as the minimum and maximum number of items it is allowed to contain.
This is only adding the (optional) field to the protocol. All users of the updated rust structs will need to be updated to use the new structs before the new field is populated.
Things that will need updated to use the updated rust structs include:
derive-typescriptderive-typescript: update dependencies #1821source-kafkaandsource-http-ingestsource-{http-ingest,kafka}: update flow protocol pin connectors#2197flowctltov0.5.8flow-gitpod-base#16 & 🚀 Release0.5.8homebrew-flowctl#23Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is