close out a number of TODOs which have been resolved #1814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psFried
approved these changes
Dec 6, 2024
crates/assemble/src/lib.rs
Outdated
| @@ -384,14 +386,10 @@ pub fn journal_selector( | |||
| ) -> broker::LabelSelector { | |||
| let mut include = labels::build_set([ | |||
| (labels::COLLECTION, collection.name.as_ref()), | |||
| // TODO(johnny): Enable this as soon as the label prefix change has propagated | |||
| // to all connectors, such as derive-typescript. | |||
| /* | |||
| ( | |||
| "name:prefix", | |||
There was a problem hiding this comment.
What's the purpose of this? Seems like this new selector is essentially equivalent to the old one. And aren't they implicitly ANDed together anyway? What am I missing?
There was a problem hiding this comment.
There's a performance optimization in gazette where it uses name:prefix to efficiently seek to the range of possible matches. Same with id:prefix. We use both estuary.dev/collection and name:prefix already in a number of places, and now use it across the board with this change. I'd held this particular instance back because connectors need to be able to parse it and needed the protocol update.
jgraettinger
force-pushed
the
johnny/todos
branch
4 times, most recently
from
17efd1d to
5719b8e
Compare
* deploy-agent-api, deploy-data-plane-controller, and derive-typescript are merged. * Continue to clear the `internal` field in flow-connector-init. There's no use case for sending it into connectors. * No current plan to implement a Destroy data-plane-controller message. * Current UI is generating tokens via /authorize/user/task
jgraettinger
force-pushed
the
johnny/todos
branch
from
5719b8e to
794c32e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deploy-agent-api, deploy-data-plane-controller, and derive-typescript are merged.
name:prefixsupport has been live for some time now.Continue to clear the
internalfield in flow-connector-init. There's no use case for sending it into connectors.No current plan to implement a Destroy data-plane-controller message.
Current UI is generating tokens via /authorize/user/task
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is