Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in DSTContract.sol submitHKGProposal #10

Open
kpii opened this issue Feb 16, 2017 · 1 comment
Open

Bug in DSTContract.sol submitHKGProposal #10

kpii opened this issue Feb 16, 2017 · 1 comment

Comments

@kpii
Copy link

kpii commented Feb 16, 2017

In submitHKGProposal() the parameter requestValue is an amount in HKG. According to the whitepaper, it should be "possible to request up to 20% of the HKG funds every 2 weeks".

The corresponding check in the code should compare requestValue with the HKG balance of the contract (e.g. using getHKGOwned()).

However, on lines 392 and 397 requestValue is checked against preferedQtySold which is a value in DST tokens.

If preferedQtySold is higher than the HKG balance this allows to submit a proposal for a higher amount, up to the full HKG balance of the contract.
@romanman
Copy link
Contributor

@mkalinin : do you think it is duplicate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kpii @romanman